Skip to content

test(dialogs): add jest-axe accessibility tests - #784

Merged
mikewheeleer merged 1 commit into
Talenttrust:mainfrom
unajiogenyi05-hub:test/dialogs-11-axe
Jul 26, 2026
Merged

test(dialogs): add jest-axe accessibility tests#784
mikewheeleer merged 1 commit into
Talenttrust:mainfrom
unajiogenyi05-hub:test/dialogs-11-axe

Conversation

@unajiogenyi05-hub

Copy link
Copy Markdown
Contributor
  • Fix ConfirmDialog cancel button missing className (no focus styles)
  • Add ConfirmDialogAxe.test.tsx with 16 axe assertions covering: closed state, default loaded, destructive/alertdialog, edge-case content, background isolation, and focus-ring class verification
  • All 16 tests pass with zero axe violations

Description

Closes #

Type of Change

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor (no functional change, internal code improvement)
  • Documentation update

Pre-flight Checklist

All items must be checked before requesting review.

  • npm run lint passes with no errors
  • npm test passes with no failures
  • npm run build completes successfully

Testing & Coverage

  • Module test coverage for impacted files meets or exceeds the 95% minimum threshold
    (run npm test -- --coverage and check the per-file table)
  • If this PR adds or modifies UI components, accessibility tests were written using
    the shared utilities in src/test-utils/a11y.tsx

What was tested?


Accessibility & Security Notes

Accessibility

Security

closes #641

- Fix ConfirmDialog cancel button missing className (no focus styles)
- Add ConfirmDialogAxe.test.tsx with 16 axe assertions covering:
  closed state, default loaded, destructive/alertdialog, edge-case
  content, background isolation, and focus-ring class verification
- All 16 tests pass with zero axe violations
@drips-wave

drips-wave Bot commented Jul 25, 2026

Copy link
Copy Markdown

@unajiogenyi05-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mikewheeleer
mikewheeleer merged commit 63c3cf2 into Talenttrust:main Jul 26, 2026
CodeMasked pushed a commit to CodeMasked/Talenttrust-Frontend that referenced this pull request Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add automated accessibility (jest-axe) tests for the dialogs view

2 participants